facebookresearch/ReAgent

Enable Quantiles

davidsc-unity3d opened this issue · 1 comments

I had some trouble getting the Quantile feature normalization running - I discovered that it had been turned off

+++ b/ml/rl/workflow/create_normalization_metadata.py
@@ -93,7 +93,9 @@ def get_norm_params(norm_params):
             "quantile_k2_threshold", DEFAULT_QUANTILE_K2_THRESHOLD
         ),
         "skip_box_cox": norm_params.get("skip_box_cox", False),
        "skip_quantiles": True,  # Skipping quantiles helps performance in OpenAI Gym Cartpole-v0

I suggest reading skip_quantiles from the config files, and just turn it off for each of the examples.

This should be easy to fix. Give us some time.