'simpleko' dcnn feature issue ?
lemonsqueeze opened this issue · 1 comments
lemonsqueeze commented
Hi,
I was looking at the input features for the dcnn and it looks like the simpleko
feature actually returns the player's stones (like the stones
feature).
in board.lua:
function board.get_stones(b, player)
local stones = torch.FloatTensor(19, 19)
C.GetStones(b, player, stones:data())
return stones
end
function board.get_simple_ko(b, player)
local simple_ko = torch.FloatTensor(19, 19)
C.GetStones(b, player, simple_ko:data())
return simple_ko
end
Maybe GetSimpleKo() was meant instead of GetStones() ?
yuandong-tian commented
Thanks for finding the bug! This indeed affects the feature used in DCNN. Then I need to retrain the model for a better performance.