facioquo/stock-indicators-python

ROC is missing `Momentum` return value

hmuhdkamran opened this issue · 3 comments

hmuhdkamran commented

The problem

in indicator roc.py has missing momentum, you should add the following lines in it

Error message(s):

    @property
    def momentum(self) -> Optional[float]:
        return self._csdata.Momentum

    @momentum.setter
    def roc_sma(self, value):
        self._csdata.Momentum = value
DaveSkender commented

@LeeDongGeon1996 do you want to sneak this into your next release?

  • 🚀1
LeeDongGeon1996 commented

@hmuhdkamran Thank you for reporting. I'll include this feature in this release.

DaveSkender commented

This was implemented in v1.2.1