faif/python-patterns

Gradually add type hints to the examples

rednafi opened this issue · 4 comments

rednafi commented

A few examples (like the delegation pattern) can be difficult to understand without type hints. Unless you want to keep backward compatibility with older Python versions, adding type hints can make the intents of the code snippets clearer.

faif commented

That is a good suggestion. Backward compatibility is not extremely useful, since Python 2.x has reached EOL

  • ❤️2
rednafi commented

Yeah, since you can add the type hints gradually, it shouldn't be problem to convert. I've already added type checking to the delegation pattern and sent a PR.

fkromer commented

That is a good suggestion. Backward compatibility is not extremely useful, since Python 2.x has reached EOL

"Le roi est mort, vive le roi" 😉

  • ❤️1
faif commented

Closing it since the effort has already started. Thanks @rednafi

  • 🚀1