Example in docs seems wrong
Closed this issue · 2 comments
patrickptm commented
- The example presents using props like this:
<ReactLoading type={type} color={color} height='667' width='375' />
However not specifying px in height and width results in a weird behaviour (it's either not working or it occupies the entire page.
This seems to be the correct way:
<ReactLoading height='25px' width='25px' />
- This also applies to "delay" props:
<ReactLoading delay="10ms" />
- the way to make it work, but still throws a warning.
<ReactLoading delay="10" />
- throws a warning.
fakiolinho commented
Hmm you are definitely right @patrickdronk
fakiolinho commented
Ok 1 is fixed so only numbers are expected and 2 is normal since only numbers are expected for delay too. Closing this thanks again 👋