fako1024/slimcap

Provide proper PacketType type / iota

Closed this issue · 1 comments

fako1024 commented

For readability it would be helpful to have an actual enum providing the same named packet type (a.k.a. direction w.r.t. interface) as provided by the linux kernel.

DoD

  • Add proper enum with human readable names
  • Check if current logic is actually correct (packetType == 0 for inbound)
  • Delete branch (got merged together with #14 without explicit review / approval)
fako1024 commented

Reopening because technically the PR wasn't seen / approved yet an the changes got merged automatically with #14 .