fako1024/slimcap

Remove debugging statements in ring buffer source

Closed this issue · 3 comments

fako1024 commented

There are several debugging statements currently in place in the nextPacket() method of the ring buffer source used to check for buffer under-/overruns in the wild. Prior to release those should be removed.

DoD

  • Remove debugging statements
  • Check remaining TODOs in code
  • Consider keeping some (using regular logging facilities or other means)
fako1024 commented

Added performance label since at the current (and future) level of optimization the additional checks performed for the debugging statements actually affect performance.

fako1024 commented

@els0r Since you've already done some production-grade alpha testing in els0r/goProbe#131 I was wondering if you could do a quick grep for the string WUT in the goProbe logs to see if there are any occurrences. I'd hope not, but who knows. Much traffic, many interfaces etc...

els0r commented

More qualitative than quantitive answer: spot checks didn't reveal any WUTs (they would have caught my eye).

I will pipe a longer running test into a log file and provide a more conclusive answer.