Value of `OTLP_TRACES_PROTOCOL` is set to the `endpoint`

[carlreid]

Describe the bug

Although the README describes the following:

config.otlp.traces.protocol | string | "" | OTLP protocol http/json, http/protobuf, grpc (default: "" which uses SDK default: http/json) |

The value of the OTLP_TRACES_PROTOCOL is being set to the same value as .Values.config.otlp.traces.endpoint.

How to reproduce it

Try set config as;

  falcosidekick:
    enabled: true
    fullfqdn: true
    webui:
      enabled: true
      disableauth: true
      replicaCount: 1
    config:
      otlp:
        traces:
          endpoint: "http://my-collector-endpoint:4318/v1/traces"
          protocol: "http/json"
          checkcert: false

Then observe protocol is not passed.

Expected behaviour

That the OTLP_TRACES_PROTOCOL is being set to the config.otlp.traces.protocol value.

[Issif]

You're write, this is typo. The fix is now included in the PR #740

[carlreid]

I did open a PR for this too though already: #742

Of course do it whichever way 👍

Edit: Ah I see your comment over there.

[Issif]

The PR #740 has been merged with the fix