falood/file_system

Backends should stop on EXIT

josevalim opened this issue · 2 comments

The backends have this code:

  def handle_info({:EXIT, port, _reason}, %{port: port}=state) do
    send(state.worker_pid, {:backend_file_event, self(), :stop})
    {:noreply, state}
  end

Shouldn't the return be {:stop, :normal, state}? Otherwise the backend will continue running even if they have no port? Or is this intentional?

It's a bug, should return {:stop, :normal, state}, will fix it soon.

fixed via d280e26