famiu/feline.nvim

Unimplemented theme support

czaplicki opened this issue · 5 comments

The add_theme function mentioned in the documentation isn't mentioned anywhere in code and does seem to be unimplemented.
I can go around it for now, but would be great have it ^^

Thanks in advanced Czaplicki

It was implemented at 47dc59e but removed for at 791c4b2.
Was theme support meant to be removed alongside presets @famiu ?

famiu commented

It was implemented at 47dc59e but removed for at 791c4b2. Was theme support meant to be removed alongside presets @famiu ?

yes, but it seems I forgot to remove it from documentation

why was it removed? what do i use now?

@famiu Could you at least add components = function() end ?

Being a table broke the ability to change colorscheme on the fly, I currently have to add a workaround:

https://github.com/catppuccin/nvim/blob/79ae9396bda299041be70c6bb0ccee07a846a6ff/README.md?plain=1#L405-L417

You should allow us then to use link within the options, instead of having to always get the hex and set fg to the hex.
It would make it also easier because you could just use the table to directly set the group.
Also I don't think there should be default highlight applied, since then SmiteshP/nvim-navic for example cannot change the color.