fannheyward/coc-pyright

[question] VSCode support

ethanc8 opened this issue · 5 comments

ethanc8 commented

What would it take to make coc-pyright work on VSCode? It provides some features that Pyright extension doesn't provide, so it would be useful for the open-source VSCode forks such as VSCodium and Theia so that they can have better Python support.

ethanc8 commented

Also, how many of the features such as:

  • semanticTokens highlighting!
  • inlayHints supports
  • codeActions to add imports, ignore typing check, run tests and more
  • linting with bandit, flake8, mypy, ruff, prospector, pycodestyle, pydocstyle, pyflakes, pylama, pylint, pytype
  • formatting with ruff, yapf, black, autopep8, darker, blackd, pyink
  • testing with unittest or pytest, supports codeLens
  • sort imports with ruff, isort and pyright
  • extract method and variables with rope

could be provided by the language server instead of by the extension? Then these features could be used by any LSP client, not just coc-pyright.

ethanc8 commented

Now that I look at it, it looks like basedpyright is the way to go, especially since Pyright is openly hostile towards bug reports and improvements now. They provide a VSCode extension and a better language server with some Pylance features.

fannheyward commented

No plan for this.

ethanc8 commented

This was not exactly a feature request, this was a question about how feasible it would be for others to do it.

fannheyward commented

how feasible it would be for others to do it.

It's possible to add features to language server itself, basedpyright has done in this way.

  • 👍1