farcaster-project/farcaster-node

refactor: increase naming distance between walletd & swapd.wallet

Lederstrumpf opened this issue · 0 comments

as we've noted during review of #789, the naming of walletd and swapd::Runtime::wallet is confusingly close.

A resolution proposed by @TheCharlatan is to rename swapd::Runtime::{wallet->swap_key_manager}, or something along those lines. This feels more descriptive since swapd::Runtime::wallet does not, say, create keys on the fly when required, like an HD wallet would: it gets these injected by walletd.