farin/JCloisterZone

Festival - followers rule

stanolacko opened this issue · 2 comments

When plaing Festival and followers rule set for festival,
festival tile dosn't allow to return any meeple.
By rule it has to be not followers but figures and it has to allow return any of player's figure.

Checked codes and FestivalCapability and it working as designed.
Problem is in Client. Barn in MeepleLayer doesn't have selectable circle defined.
Plus it's important to rename options for rule in client to use names used in rules
Meeple = Follower = Small Meeple, Large Meeple, Mayor, Wagon, Ringmaster, Phantom
Special figure = Builder, Pig, Barn, Shephers.

So current "meeple" rule has to be "figure"
and current "follower" rule has to be "meeple".

@farin Do I create Issue on Client or I'll keep it onle here (because, issue is related to client, not with Engine).

Ok. There is bug in client:
if ("follower".equals(state.getStringRule(Rule.FESTIVAL_RETURN))) { meeples = meeples.filter(Predicates.instanceOf(Follower.class)); }
It has to be "followers".

Or update Client with correct names and use value "follower" instead of "followers" for rule