Invalid filter: 'length_is' in change_form with Django 5.1

Question

Invalid filter: 'length_is' in change_form with Django 5.1

guercusguo opened this issue 4 months ago · 10 comments

Due to:
The length_is template filter is removed in Features removed in 5.1.

In template /env/lib/python3.12/site-packages/jazzmin/templates/admin/includes/fieldset.html, error at line 22

Invalid filter: 'length_is'

12
{{ fieldset.description }}

{%endif%}

{% endif %} {% for line in fieldset %}

{% for field in line %} {{ field.field.label\|capfirst }} {% if field.field.field.required %} * {% endif %}

Answer 1 · 2024-08-14T00:53:15.000Z

Also seeing this - is there a known fix?

Answer 2 · 2024-08-14T05:34:50.000Z

This is solution, change your django version, downgrade to 5.0.1

pip3 install django==5.0.1

Answer 3 · 2024-08-14T08:00:52.000Z

As a temporary workaround, copy over the file templates/admin/includes/fieldset.html from jazzmin to your project and replace the length_is filter as explained in the Django release notes: https://docs.djangoproject.com/en/5.1/releases/4.2/#id1

My working fieldset.html for Django 5.1 looks like this now:

{% load jazzmin %}
{% if card %}
<div class="card {{ fieldset.classes|cut:"collapse" }}">
    {% if card_header and fieldset.name %}
        <div class="card-header">
            <div class="card-title">
                <strong>{{ fieldset.name }}</strong>{% if fieldset.description %} - <i>{{ fieldset.description }}</i>{% endif %}
            </div>
        </div>
    {%elif fieldset.description %}
    <div class="card-header">
        <div class="card-title">
            {{ fieldset.description }}
        </div>
    </div>
    {%endif%}

    <div class="p-5{% if fieldset.name %} card-body{% endif %}">
{% endif %}

    {% for line in fieldset %}
    <div class="form-group{% if line.fields|length == 1 and line.errors %} errors{% endif %}{% if not line.has_visible_field %} hidden{% endif %}{% for field in line %}{% if field.field.name %} field-{{ field.field.name }}{% endif %}{% endfor %}">
        <div class="row">
            {% for field in line %}
                <label class="{% if not line.fields|length == 1 and forloop.counter != 1 %}col-auto {% else %}col-sm-3 {% endif %}text-left" for="id_{{ field.field.name }}">
                    {{ field.field.label|capfirst }}
                    {% if field.field.field.required %}
                    <span class="text-red">* </span>
                    {% endif %}
                </label>
                <div class="{% if not line.fields|length == 1 %} col-auto  fieldBox {% else %} col-sm-7 {% endif %}
                             {% if field.field.name %} field-{{ field.field.name }}{% endif %}
                             {% if not field.is_readonly and field.errors %} errors{% endif %}
                             {% if field.field.is_hidden %} hidden {% endif %}
                             {% if field.is_checkcard %} checkcard-row{% endif %}">
                    {% if field.is_readonly %}
                        <div class="readonly">{{ field.contents }}</div>
                    {% else %}
                        {{ field.field }}
                    {% endif %}
                    <div class="help-block red">
                        {% if not line.fields|length == 1 and not field.is_readonly %}{{ field.errors }}{% endif %}
                    </div>
                    {% if field.field.help_text %}
                        <div class="help-block">{{ field.field.help_text|safe }}</div>
                    {% endif %}
                    <div class="help-block text-red">
                        {% if line.fields|length == 1 %}{{ line.errors }}{% endif %}
                    </div>
                </div>
            {% endfor %}
        </div>
    </div>
    {% endfor %}

{% if card %}
    </div>
</div>
{% endif %}

Answer 4 · 2024-08-14T11:25:08.000Z

you must be install Django==5.0.1 because Django update 7 days ago and you can read https://docs.djangoproject.com/en/5.1/releases/5.1/ this web sayt ср, 14 авг. 2024 г. в 13:01, Ronny Rentner ***@***.***>:

…

As a temporary workaround, copy over the file templates/admin/includes/fieldset.html from jazzmin to your project and replace the length_is filter as explained in the Django release notes: https://docs.djangoproject.com/en/5.1/releases/4.2/#id1 My working fieldset.html for Django 5.1 looks like this now: {% load jazzmin %} {% if card %} <div class="card {{ fieldset.classes|cut:"collapse" }}"> {% if card_header and fieldset.name %} <div class="card-header"> <div class="card-title"> <strong>{{ fieldset.name }}</strong>{% if fieldset.description %} - <i>{{ fieldset.description }}</i>{% endif %} </div> </div> {%elif fieldset.description %} <div class="card-header"> <div class="card-title"> {{ fieldset.description }} </div> </div> {%endif%} <div class="p-5{% if fieldset.name %} card-body{% endif %}"> {% endif %} {% for line in fieldset %} <div class="form-group{% if line.fields|length == 1 and line.errors %} errors{% endif %}{% if not line.has_visible_field %} hidden{% endif %}{% for field in line %}{% if field.field.name %} field-{{ field.field.name }}{% endif %}{% endfor %}"> <div class="row"> {% for field in line %} <label class="{% if not line.fields|length == 1 and forloop.counter != 1 %}col-auto {% else %}col-sm-3 {% endif %}text-left" for="id_{{ field.field.name }}"> {{ field.field.label|capfirst }} {% if field.field.field.required %} <span class="text-red">* </span> {% endif %} </label> <div class="{% if not line.fields|length == 1 %} col-auto fieldBox {% else %} col-sm-7 {% endif %} {% if field.field.name %} field-{{ field.field.name }}{% endif %} {% if not field.is_readonly and field.errors %} errors{% endif %} {% if field.field.is_hidden %} hidden {% endif %} {% if field.is_checkcard %} checkcard-row{% endif %}"> {% if field.is_readonly %} <div class="readonly">{{ field.contents }}</div> {% else %} {{ field.field }} {% endif %} <div class="help-block red"> {% if not line.fields|length == 1 and not field.is_readonly %}{{ field.errors }}{% endif %} </div> {% if field.field.help_text %} <div class="help-block">{{ field.field.help_text|safe }}</div> {% endif %} <div class="help-block text-red"> {% if line.fields|length == 1 %}{{ line.errors }}{% endif %} </div> </div> {% endfor %} </div> </div> {% endfor %} {% if card %} </div> </div> {% endif %} — Reply to this email directly, view it on GitHub <#593 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BFE2FFDN5SMOABI3XXLLFWTZRMFETAVCNFSM6AAAAABML2GXW2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOBYGA4TMMZVG4> . You are receiving this because you commented.Message ID: ***@***.***>

Answer 5 · 2024-08-20T02:09:55.000Z

Hope that #519 will be merged

Answer 6 · 2024-09-02T16:54:47.000Z

As a temporary workaround, copy over the file templates/admin/includes/fieldset.html from jazzmin to your project and replace the length_is filter as explained in the Django release notes: https://docs.djangoproject.com/en/5.1/releases/4.2/#id1

My working fieldset.html for Django 5.1 looks like this now:

{% load jazzmin %}
{% if card %}
<div class="card {{ fieldset.classes|cut:"collapse" }}">
    {% if card_header and fieldset.name %}
        <div class="card-header">
            <div class="card-title">
                <strong>{{ fieldset.name }}</strong>{% if fieldset.description %} - <i>{{ fieldset.description }}</i>{% endif %}
            </div>
        </div>
    {%elif fieldset.description %}
    <div class="card-header">
        <div class="card-title">
            {{ fieldset.description }}
        </div>
    </div>
    {%endif%}

    <div class="p-5{% if fieldset.name %} card-body{% endif %}">
{% endif %}

    {% for line in fieldset %}
    <div class="form-group{% if line.fields|length == 1 and line.errors %} errors{% endif %}{% if not line.has_visible_field %} hidden{% endif %}{% for field in line %}{% if field.field.name %} field-{{ field.field.name }}{% endif %}{% endfor %}">
        <div class="row">
            {% for field in line %}
                <label class="{% if not line.fields|length == 1 and forloop.counter != 1 %}col-auto {% else %}col-sm-3 {% endif %}text-left" for="id_{{ field.field.name }}">
                    {{ field.field.label|capfirst }}
                    {% if field.field.field.required %}
                    <span class="text-red">* </span>
                    {% endif %}
                </label>
                <div class="{% if not line.fields|length == 1 %} col-auto  fieldBox {% else %} col-sm-7 {% endif %}
                             {% if field.field.name %} field-{{ field.field.name }}{% endif %}
                             {% if not field.is_readonly and field.errors %} errors{% endif %}
                             {% if field.field.is_hidden %} hidden {% endif %}
                             {% if field.is_checkcard %} checkcard-row{% endif %}">
                    {% if field.is_readonly %}
                        <div class="readonly">{{ field.contents }}</div>
                    {% else %}
                        {{ field.field }}
                    {% endif %}
                    <div class="help-block red">
                        {% if not line.fields|length == 1 and not field.is_readonly %}{{ field.errors }}{% endif %}
                    </div>
                    {% if field.field.help_text %}
                        <div class="help-block">{{ field.field.help_text|safe }}</div>
                    {% endif %}
                    <div class="help-block text-red">
                        {% if line.fields|length == 1 %}{{ line.errors }}{% endif %}
                    </div>
                </div>
            {% endfor %}
        </div>
    </div>
    {% endfor %}

{% if card %}
    </div>
</div>
{% endif %}

Tnxs, i was wondering if I didn't do something right, because I used it 3 weeks ago with Django 5.0 it worked, I was like why

Answer 7 · 2024-09-07T11:26:42.000Z

To clarify the above comment, you should have a folder specified in your settings.py file for 'templates':

TEMPLATES = [
    {
        'BACKEND': 'django.template.backends.django.DjangoTemplates',
        'DIRS': [
            'templates',
            ],
        'APP_DIRS': True,
        ...
   }
]

Then copy the file from the previous comment into the 'templates' using the same path as the file in the jazzmin package, like templates\admin\includes\fieldset.html.

Then copy/edit the file so that it matches the above.

Answer 8 · 2024-10-12T11:26:52.000Z

Hi, is this fixed there currently SQL Injection(not only) issue with Django==5.0.1 version which is the workaround of this issue.
@farridav

Answer 9 · 2024-10-21T07:28:01.000Z

This has been fixed with https://github.com/farridav/django-jazzmin/releases/tag/v3.0.1

Answer 10 · 2024-10-21T08:45:16.000Z

Okay, thanks. I will update to this version.