fartashf/vsepp

Same meanr being logged by tb_logger during validation

averyma opened this issue · 1 comments

averyma commented

Hello Fartash,

A small issue that I noticed: there is no meanri for t2i and the same meanr from i2t is being logged by the tb_logger during validation.

vsepp/train.py

Line 209 in cb5561a

tb_logger.log_value('meanr', meanr, step=model.Eiters)

and

vsepp/train.py

Line 214 in cb5561a

tb_logger.log_value('meanr', meanr, step=model.Eiters)

Awesome work and hats off to you for still maintaining the repo.

Regards,
Avery

fartashf commented

Hi Avery,

Good catch. Thanks. The printed statements were correct but the ones logged using tb_logger were wrong. Commit 7f8ffd5 has fix that. We did not report meanr, meanri in the paper so the change does not concern the numbers in the paper.

Thank you for reporting the issue and using the code.

Fartash

  • 👍1