Rounded corners to bottom sheets

Question

Rounded corners to bottom sheets

fartem opened this issue 5 years ago · 9 comments

fartem commented 5 years ago

Add rounded corners to bottoms sheets.

Answer 1 · 2020-03-05T18:40:13.000Z

Hi @fartem may i help you to solve this issue?

Answer 2 · 2020-03-05T19:42:32.000Z

Hi @fartem may i help you to solve this issue?

Hi. Yes.

Answer 3 · 2020-03-06T08:22:22.000Z

Dear @fartem there are problem in syncing gradle . can you help me ?

Build file '/Informations/project/Git/crypto-tracker/build.gradle' line: 16
Plugin [id: 'io.gitlab.arturbosch.detekt', version: '1.2.2'] was not found in any of the following sources:

Answer 4 · 2020-03-06T08:47:11.000Z

@alirezanazari I'm updated detekt plugin version to 1.6.0 and tested downloading and build on my PC. You can get changes from the last commit.

Some notes about working with the app:

you can use debug flavor if you cannot have a CoinMarketCap account (flavors changing in Android Studio);
in .travis.yml you can find all Gradle tasks for running all needed checks.

Answer 5 · 2020-03-06T09:56:59.000Z

Dear @fartem this issue fixed and i send PR .
#6

i saw problems in theme switching if you want i fixed theme which switching smothely .

Answer 6 · 2020-03-06T09:59:09.000Z

Dear @alirezanazari It would be great to fix theme switching

Answer 7 · 2020-03-06T10:04:37.000Z

ok . please create new issue and i fix it as soon as possible

Answer 8 · 2020-03-06T10:12:10.000Z

@alirezanazari Can you tell me about theme switching problems?

Answer 9 · 2020-03-06T10:21:51.000Z

Yes sure
you should use single activity pattern and based on your code you have one fragment and used this pattern , what you need is update preferences and detach/attach your fragment manager and your theme updated at run time without closing activity .