Broken tests

Question

mcollina opened this issue 8 months ago · 8 comments

Currently the tests on master fails.

Answer 1 · 2024-02-05T13:59:22.000Z

Pinned down the breaking to release of fastq v1.17.0. Last working with fastq v1.16.0

Answer 2 · 2024-02-05T14:02:10.000Z

I would say that the test is not broken, but fastq shipped breaking change in minor.

Answer 3 · 2024-02-05T14:07:23.000Z

mcollina/fastq#81 didn't look breaking at all.

Answer 4 · 2024-02-05T14:08:03.000Z

Confirmed it breaks avvio somehow. Essentially the .ready() method is not called.

Answer 5 · 2024-02-05T14:08:35.000Z

It changed the test a lot, so it does not guarantee nothing is not broken.

Answer 6 · 2024-02-05T14:10:52.000Z

The drain event is not emitted somehow.

Answer 7 · 2024-02-05T14:23:31.000Z

Found the bug, PR incopming

Answer 8 · 2024-02-05T14:36:45.000Z

Yep. The tests pass now.