fastify/avvio

Inconsistent or not documented "close" interface

StarpTech opened this issue · 5 comments

StarpTech commented

First discussed here

When the queue is not empty and a close handler was added the context is passed instead error.

In all cases of close the user expects an error.

mcollina commented

Definitely.

Would you be able to send a PR?

StarpTech commented

What's your expectation?

mcollina commented

To respect the API defined in https://github.com/mcollina/avvio#close.

StarpTech commented

I will prepare a PR