fastify/benchmarks

Setup CI for pull requests

dougwilson opened this issue · 1 comments

There is a npm test script included in the module. Can someone with privileges set this up in CI so the result shows in pull requests?

It currently fails because no one realized that some PRs were not passing before merging because there is no CI.

$ npm test

> fastify-benchmarks@0.3.4 test /Users/doug.wilson/Code/NodeJS/fastify-benchmarks
> standard | snazzy

standard: Use JavaScript Standard Style (https://standardjs.com)
standard: Run `standard --fix` to automatically fix some problems.

/Users/doug.wilson/Code/NodeJS/fastify-benchmarks/benchmark-bench.js
  92:1  error  Expected indentation of 4 spaces but found 2
  93:1  error  Expected indentation of 6 spaces but found 4
  94:1  error  Expected indentation of 4 spaces but found 2

/Users/doug.wilson/Code/NodeJS/fastify-benchmarks/benchmarks/@leizm-web.js
  3:46  error  Extra semicolon
  5:26  error  Extra semicolon

/Users/doug.wilson/Code/NodeJS/fastify-benchmarks/benchmarks/trek-engine-router.js
  26:7   error  Expected literal to be on the right side of ==
  26:11  error  Expected '===' and instead saw '=='

/Users/doug.wilson/Code/NodeJS/fastify-benchmarks/benchmarks/trek-engine.js
  15:7   error  Expected literal to be on the right side of ==
  15:11  error  Expected '===' and instead saw '=='

✖ 9 problems
npm ERR! Test failed.  See above for more details.

Hi! Thank you for pointing this out!
I'll enable travis :)