fastify/fastify-rate-limit

Retry-After should use units of seconds

Forty-Bot opened this issue · 2 comments

Description

The Retry-After header uses units of milliseconds.

Steps to Reproduce

Make enough requests to be rate-limited and observe that Retry-After has incorrect semantics.

Expected Behavior

The Retry-After header should use units of seconds.

c43721 commented

https://github.com/fastify/fastify-rate-limit/tree/master#ietf-draft-spec-headers

Looks like this is configurable, but shouldn't this be the default?

This was alread fixed in #307