fastlane/frameit-frames

Renaming Frame "Apple iPad Pro" to "iPad Pro (12.9-inch) (2nd generation)"?

dhermanns opened this issue · 4 comments

dhermanns commented

Hi!

This way it would match the name of the device you have to upload to the App Store.
Right now you will get an error message that the corresponding frame is missing.

I was only able to recognize the correct name be having a look at #18 .

bb-git commented

So whats the correct name? I'm trying to rename the 4th gen screenshots to be put in the right frame, but it's not working. I tried:

iPad Pro (12.9-inch) 
Apple iPad Pro
iPad Pro (12.9-inch) (2nd generation)
iPad Pro 12.9-inch (2nd generation)

but I always see

Framing screenshot './en-US/iPad Pro (12.9-inch)-1_Workouts.png'
Tried looking for offset information for 'portrait', Apple iPad Pro in ''
Could not find offset_information for './en-US/iPad Pro (12.9-inch)-1_Workouts.png'

Is it possible it's not the frame but the offset information?

dhermanns commented

For me "Apple iPad Pro" works fine. But you have to create another xcode simulator with the same name, since the default Xcode Name is currently „iPad Pro (12.9-inch) (2nd generation)“.

I think all people with iPad screenshots have to have these problems...

bb-git commented

I solved it by changing the filename to

iPad Pro

and adding

    "iPad Pro": {
      "offset": "+96+102",
      "width": 2048
    },

to ~/.fastlane/frameit/latest/offsets.json

Offsets I took from the 4th gen, so probably needs adjustment.

imWildCat commented

This needs to be fixed. If not, frameit would become useless because iPad Pro (12.9-inch) (2nd generation) is required for App Store.