fastly/cli

New CLI version blocks deployment due to package size

platy opened this issue · 4 comments

platy commented

Version

Fastly CLI version v10.2.3 (6cdda9c)
Built with go version go1.20.6 linux/amd64
Viceroy version: viceroy 0.6.0

What happened

I ran

fastly compute deploy

and it deployed like normal, then I ran

fastly update

and updated the CLI to the version released today, then ran deploy again and got the error:

ERROR: package size exceeded 100MB limit.

I was expecting it to deploy my app again. There hasn't been a large change in package size for a while, compressed it is well under 100MB, but uncompressed it is well over, I assumed that the limit applied to the compressed archive as otherwise we would be over the limit.

Is this an error, introduced in the new version, or is this correcting an error to enforce a limit which wasn't previously enforced? Though I assume some limit is enforced on the backend, but that must be a different limit to this.

Integralist commented

👋🏻 Hi @platy

Were you using v10.2.2 prior to this and the error wasn't present in that version?

There was a change made in the CLI (back in May) related to package size but if anything this change was to increase the size 🙂

2d4de81

In the above change set (released in version v10.1.0) the size of the package was 50mb and we up'ed it to 100mb (because that was the actual limitation on the API side).

Thanks.

platy commented

Hi @Integralist

I don't have this issue with v10.2.2, I've confirmed that by grabbing the binary release for it and no problems. The error I'm hitting is a check on the sum of the files inside the archive, not on the overall package size. It isn't new in the latest version, but the code for it did move, so maybe it moved from a path I wasn't hitting to one that I now am.

What is this code for, it definitely looks like it is intentionally limiting the size of the contents of the package?:

b451716#diff-323540d61ef576278983a97fd16cf6af59fbacded7d0b250bc97cd54718df94aR108-R121

  • 👍1
Integralist commented

Hi @platy

Would it be possible to locate me on the Fastly support Slack so you can send me the problematic .tar.gz package you're trying to upload. You can also email me integralist@fastly.com.

Thanks!

  • 👍1
Integralist commented

Closing for now as we have removed the faulty logic in the CLI (see PR #984)

https://github.com/fastly/cli/releases/tag/v10.2.4

  • 👍2