Dev server with the "dumb" hot reloading

Question

Dev server with the "dumb" hot reloading

zindel opened this issue 6 years ago · 17 comments

I've started the refactor this weekend with the main goal to provide the accurate and machine-friendly reporting using the --report=json option. If you're curious see the refactor/flat-packer branch. In fact this is just the beginning of it. I'm also planning to optimize and re-structure the production mode bundling (tree-shaking), but that'd take another week or two.

In this issue I wanted to start the discussion and ask for some help implementing the integration with the dev server. I am not really experienced with the Node-based backend development, so any feedback or prototyping is much appreciated.

The server may work as following:

Accept few basic options required for running (--host, --port, etc) + all the fastpack original options (except maybe --development which is always set and --report which is always set to json).
Start the fpack process in a watch mode with the provided options and capture its stdout/stderr.
Start the web socket server and inject the websocket client code to any html file served.
On receiving the "ok" event from fpack ping clients and ask them to simply reload the page.
On receiving the "error" event - send the error to clients. They will have to show it in the browser.

Thank you!

Answer 1 · 2018-07-09T07:47:49.000Z

I'm currently working on a small react app and using webpack's dev server with hot reloading. Would love to give pointers and help with testing. (will try to contribute as well, but I'm a bit stretched these days).

Answer 2 · 2018-07-09T07:50:10.000Z

@rauanmayemir Thanks. I will ping you when it will be ready for testing.

Answer 3 · 2018-07-09T08:11:24.000Z

I could help with testing on another react app which has cra-like setup. Would also be interested in directly contributing if there are any low-hanging fruits.

Answer 4 · 2018-07-09T11:47:55.000Z

Former maintainer of webpack-dev-server, and current maintainer of webpack-serve, webpack-hot-client, webpack-dev-middleware (...the list goes on). I'd be happy to help get a dev server going for you all (that is of course, if it was cool if JavaScript was used - I'm afraid I'm not a ReasonML dev)

Answer 5 · 2018-07-09T15:25:57.000Z

@shellscape Thanks for offering the help! Mind if we ask you to review & provide feedback on the @TrySound's initial implementation? And yes, we plan to use JavaScript for it

Answer 6 · 2018-07-09T15:38:10.000Z

@zindel absolutely, can you point me in a direction towards it?

Answer 7 · 2018-07-09T19:05:12.000Z

@shellscape will do once @TrySound has something ready :) @TrySound do you mind if we keep it in one repo/npm package for now? We can place it in node-service/ if you don't mind.

Answer 8 · 2018-07-09T19:33:08.000Z

@zindel I thought about providing apis like this

import { build, serve } from 'fpack';

build({
  // options
})

serve({
  // options
})

Answer 9 · 2018-07-10T06:39:15.000Z

@TrySound maybe we can postpone creating the JS API for now? I think the fpack API may change significantly and JS API will go out of sync. I think the ideal solution would be to blindly pass the remaining command-line options to the fpack binary and let it do its job. Some knowledge is obviously needed though:

always pass --report=json
always pass -w
always pass --development

Everything else may go as is. Thoughts?

Answer 10 · 2018-07-10T06:53:40.000Z

I think a simple idiomatic JS API is needed, we can’t expect people providing command line arguments when using fastpack from node. We can use a simple mapping bug from JSON to command line arguments though.

…

On Tue, 10 Jul 2018 at 09:39 Oleksiy Golovko ***@***.***> wrote: @TrySound <https://github.com/TrySound> maybe we can postpone creating the JS API for now? I think the fpack API may change significantly and JS API will go out of sync. I think the ideal solution would be to blindly pass the remaining command-line options to the fpack binary and let it do its job. Some knowledge is obviously needed though: - always pass --report=json - always pass -w - always pass --development Everything else may go as is. Thoughts? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#92 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAB3gsIA2Qjx4srjjAvtxCMi4ONRhL-iks5uFEwTgaJpZM4VHMXf> .

Answer 11 · 2018-07-10T11:23:37.000Z

We have agreed on just serve for now which is not going to be public (yet).

Answer 12 · 2018-07-19T18:40:15.000Z

Guys, I'm busy these days. It's better to somebody else take this issue. @shellscape would be great to have your experience in this.

Answer 13 · 2018-07-31T20:32:15.000Z

I hacked this together: https://github.com/ulrikstrid/fpack-dev-server

I should take a look at what @shellscape has done in the various webpack-dev-server packages to make it more robust etc but this is a really simple start.

Answer 14 · 2018-07-31T22:58:05.000Z

webpack-serve and webpack-hot-client are the two to check out. webpack-dev-server is a tire fire.

Answer 15 · 2018-08-01T06:52:56.000Z

@shellscape if you want to take this feel free. If you don't I'll slowly continue.

Thanks for the pointers!

Answer 16 · 2018-08-01T12:53:21.000Z

It'll be a few weeks for me (offline is crazy right now, including an inoperable thumb of all things), but I'll star your repo and see about where I can help your effort when I'm able.

Answer 17 · 2018-08-15T20:23:41.000Z

There is an open PR but I also have this playground repo that I've been toying with if anyone is interested to have a look https://github.com/ulrikstrid/fastpack-devserver-playground.

It basically works but I need to add more inputs with cmdliner and also have a real implementation of a websocket client that gets injected into the html or something like it.