Provide Join/create instead option
Closed this issue · 7 comments
Is your feature request related to a problem? Please describe. 💡
Assuming the following situation:
A user might have code for a room. He/she visited the play page, and clicked on create game by mistake instead of join game.
In such case, the user has to manually reload the page in order to click on join game again.
In order to prevent this, we can have a small link/button on the lobby code dialog, clicking on which user can cancel new room action and join to a game instead
Similar situations might hapeen the other way. Someone had to create a game, but click on join by mistake.
Describe the solution you'd like ✨
A link/button to bottom-left of copy code dialog, similar to Login instead we see on sign up pages. It would cancel the create room process and replace it with the join room dialog.
Similar link/button to replace join room dialog with create room dialog
Additionally, what is the extra comma that appears after copy code button?
It is there by mistake, we can remove that if it is so.
Additional context 📝
Something like this:
Can you assign this me under GSSoC 21
My discord: Omkar Phansopkar (P)
Also, there are a few console.log statements lying around. Shouldn't we remove them?
@fave77 Seems a good addition to me 👍
Additionally, what is the extra comma that appears after copy code button?
It is there by mistake, we can remove that if it is so.
I think it's by mistake, take a look at the end of line 179->
pbchess/client/src/components/lobby/lobby.js
Lines 179 to 181 in 4f41155
Also, there are a few console.log statements lying around. Shouldn't we remove them?
Seems you are talking about all these @OmkarPh ?
Seems you are talking about all these @OmkarPh ?
Yes
Should I remove them?
No need to remove console logs, they would come in handy while refactoring lobby.js
No need to remove console logs, they would come in handy while refactoring
lobby.js
Ohk 👍