fawazahmed0/hadith-api

apiscript.js removes the ending punctuations.

Opened this issue · 4 comments

GibreelAbdullah commented

Noticed that the database/line-by-line is missing all the ending punctuations in English translation (Didn't check them in others). I manually added them in one file (eng-malik) and regenerated the data using apiscript update command.

The manually added punctuation was removed when the updated file was created in line-by-line folder.

fawazahmed0 commented

Yeah, actually the clean up is happening here, specifically this line .
The above code was taken from quran-api

This could be fixed using Unicode property escapes (i.e using something like \P{P} which will ignore puntuations).

Could you share me the file with punctuation?

GibreelAbdullah commented

I just added a full stop (.) at the end of hadith 1 of eng-malik to verify.

GibreelAbdullah commented

I would like to connect with you @fawazahmed0 . If you are ok kindly message me on telegram https://t.me/GibreelAbdullah

fawazahmed0 commented

Brother, I don't regularly use telegram etc. But I do use my email regularly.

Anyways, the original files with puntuations, dots etc should be available at here and malik is here.

After fixing this issue the files needs to be regenerated and inshallah will look into this later.