faxm0dem/puppet-syslog_ng

check changes in the config file instead of the temporary config file.

Closed this issue · 7 comments

HanzzM commented

The module don't enforces the desired state from the config file syslog-ng.conf.
I can freely change the config file on my local node.

ihrwein commented

I solved this by using file's validate_cmd parameter, but that's only supported after Puppet 3.4.3... I will try to find a backward compatible solution.

faxm0dem commented

I think there is a misunderstanding on this issue. @HanzzM was referring to the fact that it is possible to modify the deployed syslog-ng.conf file, and not the temporary one. Please repoen this issue, and I'll cook a patch ASAP

ihrwein commented

Thanks, I reopened it!

faxm0dem commented

yeah so the problem is:

  file {$config_file:
    ensure => present,
    path   => $config_file,
    require => Concat[$tmp_config_file]
  }

when puppet doesn't manage a file resource's content, there's no way to notify other resources when it changes (change requires content management).
So IMHO there's no sane way to solve this with the current implementation using $tmp_config_file.
IMHO the only sane way to solve this is through #23

ihrwein commented

I checked @faxm0dem 's suggestion and it's supported above Puppet 3.5.0.

Fabien, do you know which Puppet version's are the most widespreadly used nowadays?

@HanzzM what Puppet version are you using?

HanzzM commented

sudo /opt/puppet/bin/puppet --version
3.6.2 (Puppet Enterprise 3.3.2)

HanzzM commented

Sorry, I leave this chat.
I'm no longer a user of this module.