Close before the upgrade request is handled by the server

Question

Close before the upgrade request is handled by the server

Closed this issue 10 years ago · 6 comments

The server does not close cleanly if the client closes before the upgrade request is handled.
In this gist you can find a test case to reproduce the issue.
The close event is never emitted on the server and the process never exits.

The same example "works" when using einaros/ws and it seems that the edge case is handled here.

Thank you.

Answer 1 · 2014-10-26T13:04:49.000Z

Thanks for spotting this; it's fixed in 29d07c5.

Answer 2 · 2014-10-26T13:17:05.000Z

Awesome, thank you!
Can you release the fix on npm when you have time?

Answer 3 · 2014-11-21T11:24:59.000Z

@jcoglan i was testing this and i noticed that the process exits, but the close event is not fired on the server. The close listener is never called.

Answer 4 · 2014-11-21T11:49:36.000Z

Surely that's down to Node? faye-websocket doesn't control which events the HttpServer emits.

Answer 5 · 2014-11-21T11:53:47.000Z

@jcoglan I was thinking the same, wondering if it is an issue of the http.Server or it is intended.

Answer 6 · 2014-11-24T14:14:43.000Z

I've created this issue nodejs/node-v0.x-archive#8763.
The problem seems to be caused by the fact that the stream is still writable on the server when the socket is destroyed. I still don't know why the process exits.