fd4s/fs2-kafka

Thread naming strategy

TimWSpence opened this issue · 2 comments

TimWSpence commented

Is there a reason why we append the thread id to the thread name here?

We saw fs2-kafka-consumer-78 and were worried that we'd messed up our threadpools and that the kafka actor wasn't running on a pool of size 1

bplommer commented

I guess to ensure the name is unique when there are multiple consumers? @vlovgr would know. But I think we could replace that with a global AtomicLong counter - a mildly unpleasant thing to do but I don't foresee it causing any problems.

  • 👍1
vlovgr commented

It is just to ensure uniqueness, yes. Feel free to raise a pull request with AtomicLong-based numbering.

  • 👍1