feathers-plus/graphql

join-monster-graphql-tools-adapter@0.0.2

iva2k opened this issue · 2 comments

iva2k commented

npm WARN join-monster-graphql-tools-adapter@0.0.2 requires a peer of graphql-tools@^0.4.0 but none is installed. You must install peer dependencies yourself.

package.json sets:

  "dependencies": {
    "graphql-tools": "2.0.0",
    "join-monster-graphql-tools-adapter": "0.0.2",
iva2k commented

join-monster-graphql-tools-adapter v0.0.2 pins graphql-tools to old version in peerDependencies.

join-monster-graphql-tools-adapter now is at v0.0.3, and it does not pin graphql-tools version.

Can package.json (this line) be updated (any reason not to)?

-    "join-monster-graphql-tools-adapter": "0.0.2",
+    "join-monster-graphql-tools-adapter": "0.0.3",
iva2k commented

To answer my own question, I diff'ed v0.0.3 and v0.0.2 of join-monster-graphql-tools-adapter, no code differences, only graphql-tools version unpinned, so the fix is safe.

join-monster/join-monster-graphql-tools-adapter@996caf8#diff-b9cfc7f2cdf78a7f4b91a753d10865a2