Why is there an init method in this service?
bertho-zero opened this issue · 4 comments
bertho-zero commented
Why is there an init method in this service? this method is not documented and uses knex before the application setup.
daffl commented
Dang, I should've removed that in the latest release. I don't think it is being used anywhere anymore (except for maybe the tests which can be easily changed).
bertho-zero commented
Ok, init is also used in feathers-rethinkdb.
bertho-zero commented
@daffl Should not this be removed with v4.3.0 ?
daffl commented
Oh, I forgot about this. Would you mind submitting a PR? It'll be a breaking change but it should be fine since the database adapters are versioned independently anyway.