feathersjs-ecosystem/feathers-knex

Fix types to work with knex > 0.95

xquangdang opened this issue ยท 0 comments

Hi! ๐Ÿ‘‹

Firstly, thanks for your work on this project! ๐Ÿ™‚

Today I used patch-package to patch feathers-knex@7.1.1 for the project I'm working on.

Here is the diff that solved my problem:

diff --git a/node_modules/feathers-knex/types/index.d.ts b/node_modules/feathers-knex/types/index.d.ts
index 885026f..b2ccf71 100644
--- a/node_modules/feathers-knex/types/index.d.ts
+++ b/node_modules/feathers-knex/types/index.d.ts
@@ -1,7 +1,7 @@
 // TypeScript Version: 3.7
 import { Params, Paginated, Id, NullableId, HookContext, Hook } from '@feathersjs/feathers';
 import { AdapterService, ServiceOptions, InternalServiceMethods } from '@feathersjs/adapter-commons';
-import * as Knex from 'knex';
+import { Knex }from 'knex';
 import { start } from 'repl';
 
 export interface KnexServiceOptions extends ServiceOptions {

This issue body was partially generated by patch-package.