federicoiosue/Omni-Notes

Reminder's modal dialog stays open when fast exiting note (on emulator or slow devices)

Opened this issue · 1 comments

How to reproduce:
Launch OmniNotes
Select a note from homepage
Click ‘Add reminder’
Click ‘<-’ icon quickly after
The add reminder dialog will still appear
Select a time and click ‘OK’
Reminder will not be set

Actual Behavior:
https://github.com/federicoiosue/Omni-Notes/assets/94947740/3ab33e71-ddf8-459f-b1b4-b469c58f758a

Expected Behavior:
When the note is exited after pressing 'Add reminder', either the dialog does not appear or the reminder is set even when on a different page.

Device information: Pixel_3a_API_34_extension_level_7_x86_64

App version=6.3.1
Android Studio Hedgehog | 2023.1.1 Patch 2
Build #AI-231.9392.1.2311.11330709, built on January 18, 2024
Runtime version: 17.0.7+0-17.0.7b1000.6-10550314 x86_64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o.

Nice test 😃
I believe this happens on your emulator due to performances constriction but it doesn't affect real life app usage.
Anyway this could be a good "first issue" that could be worked by ensuring that when the reminder picker dialog appears the underlying fragment is still alive and shown.