fedora-cloud/Fedora-Dockerfiles

[Minor-change] [file="README.md"] Use of 'sudo' by the root user.

Opened this issue · 5 comments

vharsh commented

The # before the command sudo dnf install docker fedora-dockerfiles shows that it was performed by the root user.
Following the best practices of not logging in as the root user, shouldn't the # be changed to a $ ?

aditya-konarde commented

+1. It doesn't make sense for the root user to use sudo for dnf. We can either execute the command directly as root or replace # with $ over there. Is anyone working on this?

mattdm commented

I agree with @vharsh on keeping with the don't-log-in-as-root practice and using $ sudo as the "do with privs" indicator rather than #.

aditya-konarde commented

I would like to work on this, may I? @mattdm

trishnaguha commented

@aditya-konarde Feel free to send the patch in a PR :).

aditya-konarde commented

Looks like I sent the PR to my own fork first(new to git). Anyway the pull request is up for review at #243. Hopefully it will be my first contribution :D

  • 👍1