Consider moving `regions` modules into `django-content-editor` application

[bkfox]

Regions class is useful for people not using feincms3 too. Since the regions module does not use any of the feincms3's modules, and offers functionalities directly linked and relevant to django-content-editor, it makes sense to move it there. It would also reduce dependencies when no other feincms3 functionalities are used.

This implies that TemplatePluginRenderer.plugins() method to be moved to PluginRenderer. Also, PluginRenderer is initialized with Model registered which causes troubles when trying to pass down plugin_renderers' plugins as:

contents = contents_for_item(page, page_renderer._renderers.keys())

(this provides an error: type object 'Model' has no attribute 'get_queryset', in contents.py in contents_for_items, line 70). This is solved by removing Model from renderer's plugins.

[matthiask]

Hi @bkfox

That might be a good idea. OTOH I consider django-content-editor to be more stable and conservative. The regions code is still relatively new, at least compared to the content editor.

Is it a problem for you to install feincms3? The only additional dependency is django-tree-queries which is really small and shouldn't be a problem having no dependencies of its own.

The PluginRenderer problem you're mentioning should be gone for good since I removed the sub-par PluginRenderer from django-content-editor a few months ago when preparing for its 2.0 release (feincms/django-content-editor@d27b029)