felddy/foundryvtt-docker

Shutting down the docker keeps the packs locked

Cussa opened this issue · 4 comments

Bug description

Hi,

Thanks for the amazing work on creating these dockers.

I am using that to run some module development and I am seeing that even if you shutdown the docker, it keeps the module packes locked.

Steps to reproduce

  • Start the docker
  • Create a module
  • Create a pack for the module
  • Edit the pack
  • Close the world
  • Shutdown the docker/foundry

Expected behavior

  • Packs are unlocked when finished to work on the server

Container metadata

com.foundryvtt.version = "11.315"
org.opencontainers.image.authors = "markf+github@geekpad.com"
org.opencontainers.image.created = "2024-01-05T17:39:23.478Z"
org.opencontainers.image.description = "An easy-to-deploy Dockerized Foundry Virtual Tabletop server."
org.opencontainers.image.licenses = "MIT"
org.opencontainers.image.revision = "18981628b89a04fa780f9faa1657be17aeaeb9b1"
org.opencontainers.image.source = "https://github.com/felddy/foundryvtt-docker"
org.opencontainers.image.title = "foundryvtt-docker"
org.opencontainers.image.url = "https://github.com/felddy/foundryvtt-docker"
org.opencontainers.image.vendor = "Geekpad"
org.opencontainers.image.version = "11.315.1"

Relevant log output

2024-03-05 19:19:43 FoundryVTT | 2024-03-05 19:19:43 | [info] Server started and listening on port 30000
2024-03-05 19:19:44 FoundryVTT | 2024-03-05 19:19:44 | [info] Created client session c16c96fe2c9ee94cff268823
2024-03-05 19:19:47 FoundryVTT | 2024-03-05 19:19:47 | [info] License signature successfully created. Thank you and please enjoy Foundry Virtual Tabletop.
2024-03-05 19:19:47 FoundryVTT | 2024-03-05 19:19:47 | [info] Software license verification succeeded
2024-03-05 19:19:51 FoundryVTT | 2024-03-05 19:19:51 | [info] FoundryVTT | Connected to database "actors"
2024-03-05 19:19:51 FoundryVTT | 2024-03-05 19:19:51 | [info] FoundryVTT | Connected to database "cards"
2024-03-05 19:19:51 FoundryVTT | 2024-03-05 19:19:51 | [info] FoundryVTT | Connected to database "messages"
2024-03-05 19:19:51 FoundryVTT | 2024-03-05 19:19:51 | [info] FoundryVTT | Connected to database "combats"
2024-03-05 19:19:51 FoundryVTT | 2024-03-05 19:19:51 | [info] FoundryVTT | Connected to database "drawings"
2024-03-05 19:19:51 FoundryVTT | 2024-03-05 19:19:51 | [info] FoundryVTT | Connected to database "fog"
2024-03-05 19:19:51 FoundryVTT | 2024-03-05 19:19:51 | [info] FoundryVTT | Connected to database "folders"
2024-03-05 19:19:51 FoundryVTT | 2024-03-05 19:19:51 | [info] FoundryVTT | Connected to database "items"
2024-03-05 19:19:51 FoundryVTT | 2024-03-05 19:19:51 | [info] FoundryVTT | Connected to database "journal"
2024-03-05 19:19:51 FoundryVTT | 2024-03-05 19:19:51 | [info] FoundryVTT | Connected to database "macros"
2024-03-05 19:19:51 FoundryVTT | 2024-03-05 19:19:51 | [info] FoundryVTT | Connected to database "playlists"
2024-03-05 19:19:51 FoundryVTT | 2024-03-05 19:19:51 | [info] FoundryVTT | Connected to database "tables"
2024-03-05 19:19:51 FoundryVTT | 2024-03-05 19:19:51 | [info] FoundryVTT | Connected to database "scenes"
2024-03-05 19:19:51 FoundryVTT | 2024-03-05 19:19:51 | [info] FoundryVTT | Connected to database "settings"
2024-03-05 19:19:51 FoundryVTT | 2024-03-05 19:19:51 | [info] FoundryVTT | Connected to database "users"
2024-03-05 19:19:51 FoundryVTT | 2024-03-05 19:19:51 | [info] FoundryVTT | Connected to database "world.kogarashi-items"
2024-03-05 19:19:51 FoundryVTT | 2024-03-05 19:19:51 | [info] FoundryVTT | Connected to database "kogarashi.kogarashi"
2024-03-05 19:19:51 FoundryVTT | 2024-03-05 19:19:51 | [info] FoundryVTT | Created 0 Folder documents with ids: []
2024-03-05 19:19:51 Watching for changes to trued6 in /data/Data/systems/trued6/lang, /data/Data/systems/trued6/css, /data/Data/systems/trued6/templates
2024-03-05 19:20:09 FoundryVTT | 2024-03-05 19:20:09 | [info] User authentication successful for user Gamemaster
2024-03-05 19:20:10 FoundryVTT | 2024-03-05 19:20:10 | [info] Created client session c3941c43adeaf3edd3c47cb0
2024-03-05 19:20:10 FoundryVTT | 2024-03-05 19:20:10 | [warn] No system manifest found at https://github.com/cussa/fvtt-true-d6/releases/download/latest/module.json
2024-03-05 19:20:10 FoundryVTT | 2024-03-05 19:20:10 | [info] No system update for TRUE-d6 is currently available.
2024-03-05 19:20:10 FoundryVTT | 2024-03-05 19:20:10 | [info] Vended World data to User [BYWnNCAU5OooUKKE] in 308ms
2024-03-05 19:21:00 Entrypoint | 2024-03-05 19:21:00 | [warn] TERM signal received.  Shutting down server.

Code of Conduct

  • I agree to follow this project's Code of Conduct

I'm glad you're finding the container useful for module development. I haven't done much of that myself yet. What do you mean by "it keeps the module packes locked"?

Whenever you are editing a pack, Foundry creates some lock files. From what I saw, it "commits" the changes to the database file when you shutdown it.

If you follow the steps, you will see that it will keep some lock files in the pack folder.

Thanks for explanation. This type of issue is probably not specific to the containers implementation, but it could be related to how you are stopping the container and the signals that are getting sent to Foundry.

How are you starting up the container? Are you using the Docker init option? This sounds similar to issue #813.

See:

@felddy Sorry for the confusion. It seems that it is not a bug, as going for other ways of operating that is causing the same behaviour. I am closing the ticket.