Not working with `@cycjimmy/semantic-release-action`

Question

Not working with `@cycjimmy/semantic-release-action`

felixjb opened this issue 2 years ago · 27 comments

When the semantic release action is executed using the vsce plugin in my repo, Testify, i get the following error:

[8:23:46 PM] [semantic-release] › ✖  EINVALIDVSCETOKEN Invalid vsce token. Additional information:

Error: Command failed with ENOENT: vsce verify-pat
spawn vsce ENOENT
Error: AggregateError: 
    SemanticReleaseError: Invalid vsce token. Additional information:
    Error: Command failed with ENOENT: vsce verify-pat
    spawn vsce ENOENT
        at module.exports (/home/runner/work/_actions/cycjimmy/semantic-release-action/v3/node_modules/semantic-release-vsce/lib/verify-auth.js:14:11)
        at processTicksAndRejections (node:internal/process/task_queues:96:5)
        at async module.exports (/home/runner/work/_actions/cycjimmy/semantic-release-action/v3/node_modules/semantic-release-vsce/lib/verify.js:8:3)
        at async verifyConditions (/home/runner/work/_actions/cycjimmy/semantic-release-action/v3/node_modules/semantic-release-vsce/index.js:10:3)
        at async validator (/home/runner/work/_actions/cycjimmy/semantic-release-action/v3/node_modules/semantic-release/lib/plugins/normalize.js:34:24)
        at async /home/runner/work/_actions/cycjimmy/semantic-release-action/v3/node_modules/semantic-release/lib/plugins/pipeline.js:37:34
        at async Promise.all (index 0)
        at async next (/home/runner/work/_actions/cycjimmy/semantic-release-action/v3/node_modules/p-reduce/index.js:16:18)

I am using the GitHub secrets to store my Personal Access Token and I double checked that the token is really there.

I also double checked the permissions of said token in the Azure Portal and it has the necessary access specified in the VSCode documentation

When I run the same command as the plugin locally, I get the following result:

The Personal Access Token verification succeeded for the publisher 'felixjb'.

Is this a bug? Am I doing anything wrong?

Answer 1 · 2022-06-02T23:09:08.000Z

This is very weird. Perhaps you may have more luck turning debug logs on?

https://docs.github.com/en/actions/monitoring-and-troubleshooting-workflows/enabling-debug-logging

Answer 2 · 2022-06-02T23:11:07.000Z

One suggestion is to run:

vsce verify-pat

Directly in your workflow.

Answer 3 · 2022-06-02T23:12:54.000Z

Alright, I'll do that right now!

Answer 4 · 2022-06-02T23:14:17.000Z

Actually, nevermind. I think the issue is due to #294 maybe. I'll check it further.

Answer 5 · 2022-06-02T23:15:10.000Z

As a temporary workaround, try to run with the last but one version of the plugin. If it works, please let me know to confirm the issue.

Answer 6 · 2022-06-02T23:15:24.000Z

So, I ran the workflow again with the debug logs on and it seems like the variable is there:

##[debug]Evaluating: secrets.VSCE_TOKEN
##[debug]Evaluating Index:
##[debug]..Evaluating secrets:
##[debug]..=> Object
##[debug]..Evaluating String:
##[debug]..=> 'VSCE_TOKEN'
##[debug]=> '***'
##[debug]Result: '***'

Answer 7 · 2022-06-02T23:16:18.000Z

Sorry, I didn't get that. I should try again with the second to last version of the plugin?

Answer 8 · 2022-06-02T23:16:43.000Z

Yes, exactly 5.0.14.

Answer 9 · 2022-06-02T23:17:08.000Z

Alright. I'll do that now

Answer 10 · 2022-06-02T23:18:34.000Z

@felipecrs Do I need to update the version in the package.json too if I'm running the workflow on GitHub Actions?

Answer 11 · 2022-06-02T23:32:34.000Z

As a temporary workaround, try to run with the last but one version of the plugin. If it works, please let me know to confirm the issue.

@felipecrs Nope, didn't work either

Answer 12 · 2022-06-02T23:48:24.000Z

@felipecrs Do I need to update the version in the package.json too if I'm running the workflow on GitHub Actions?

I don't know... never used the semantic-release-action myself, I just call semantic-release directly. Like in vscode-shellcheck.

Answer 13 · 2022-06-02T23:54:22.000Z

I just tried using a full access token and even that didn't work.

Do you think it's possible that because I didn't register a NPM_TOKEN for semantic release, as I am using the private: true option for not publishing to npm registry, it is messing up with the VSCE_PAT?

Answer 14 · 2022-06-02T23:56:42.000Z

No, I don't think so. Can you try without using the semantic-release action?

I'm trying to replicate the issue here, but without much success.

Answer 15 · 2022-06-02T23:57:27.000Z

Sure. I'll try it now

Answer 16 · 2022-06-03T00:04:27.000Z

It seems like it works without the action:

Answer 17 · 2022-06-03T00:13:03.000Z

I meant this: felixjb/testify#97

Answer 18 · 2022-06-03T00:38:49.000Z

Oh, I see! Wouldn't it be better to make the plugin work with the action?

Answer 19 · 2022-06-03T00:41:29.000Z

Yes, but first we need to make sure that's the issue indeed. Right?

Answer 20 · 2022-06-03T00:44:11.000Z

Fair enough. Can we continue on this tomorrow then? Haha

Answer 21 · 2022-06-03T00:47:14.000Z

What's happening is the following:

The plugin fails to call vsce (we use execa for that) with ENOENT (file not found)
This probably means that vsce isn't in the PATH environment variable.

Probably something different happens in the action which makes the PATH variable not be filled properly (i.e. with node_modules/.bin on it).

Answer 22 · 2022-06-03T00:53:23.000Z

Fair enough. Can we continue on this tomorrow then? Haha

@felixjb lol, sure. I'm on vacation anyways!

Answer 23 · 2022-06-03T13:24:09.000Z

@felipecrs It seems like running the semantic release directly worked! Now I have some other issues that are unrelated.

So, that is it: the plugin cannot verify the PAT when using the GitHub actions at this time. Maybe try explicitly passing the PAT and the publisher to the command can help?

Answer 24 · 2022-06-03T15:58:37.000Z

So, that is it: the plugin cannot verify the PAT when using the GitHub actions at this time. Maybe try explicitly passing the PAT and the publisher to the command can help?

I guess the correct assessment is: the plugin cannot call the vsce binary when running upon @cycjimmy/semantic-release-action.

@cycjimmy do you have any clue on why this is happening? The plugin does not do anything special, it just calls the vsce binary here, the same way other semantic-release plugins do.

The catch is that vsce comes from the NPM dependency, therefore, it's executable is on node_modules/.bin.

Answer 25 · 2022-10-21T17:54:58.000Z

I believe using execa's preferLocal option, together with #338 may fix this issue. I'll check later.

Answer 26 · 2022-10-31T07:13:07.000Z

Hey @felixjb, I published v5.2.2 which contains a potential fix for this issue. Would you mind testing it? Thanks in advance.

Answer 27 · 2022-12-03T15:09:38.000Z

I'm closing this issue as I believe it's fixed. If someone notices the opposite, please comment here and I can reopen it.