feross/drag-drop

drag-drop.min.js missing from latest release

designosis opened this issue · 4 comments

designosis commented

Release 5.0.2 ... https://github.com/feross/drag-drop/tree/v5.0.2 ... features dragdrop.min.js. This works as expected.

Release 6 ... https://github.com/feross/drag-drop ... has nothing. No minified or otherwise working code. I thought maybe index.js was your new release, which seemed strange, so I minified it and tested. But after getting a "module is undefined" error and looking deeper, I realized you probably just forgot to add it to the codebase. So my NPM update left me high and dry :)

Reinstalling with npm i drag-drop@5 --save is my temporary workaround. I'd love to know what you did in v6! You should comment your major releases so we can get excited and cheer you on.

designosis commented

Just checked out your resumé. Holy crap.

designosis commented

Seriously though, what am I missing? drag-drop.js is entirely missing, it's even in the gitignore ...

Ah, I see the standalone script (I don't use a bundler). Thank you for that. I use npm to update scripts, and gulp to compress/concatenate. I guess it's easy enough to save the standalone script each time you update. I'll try that :)

Raynos commented

f1151d8

There's a commit recommending https://bundle.run/drag-drop

Raynos commented

I'd recommend removing this package from package.json if your not using a bundler.

npm rm drag-drop --save

Then just create a vendor/drag-drop.js with the code from https://bundle.run/drag-drop@6.0.2

Feel free to add

// Manually copied from https://bundle.run/drag-drop@6.0.2

To the top of the file to make it easier to understand where it came from.

  • 👍2
  • 😄2