In case the rollout is not exist - return nil.

Question

In case the rollout is not exist - return nil.

yossi-eynav opened this issue 8 years ago · 5 comments

The method get should return nil in case rollout is no exist.
This way the behaviour of the method is more predictable.

What do you think?

yossi-eynav commented 7 years ago

#122

Answer 1 · 2017-06-13T02:33:45.000Z

@yossi-eynav rollout.get of an undefined feature already returns nil, what do you mean by "rollout is no exist"?

Answer 2 · 2017-06-13T14:22:06.000Z

yossi-eynav commented 8 years ago

Answer 3 · 2017-06-13T16:47:58.000Z

You are correct there, my apologies.

Answer 4 · 2017-06-13T17:22:52.000Z

Returning nil would be a breaking change so I'd like to avoid that if possible. But if it's very important to you I'd accept PR adding method like exists? to the Rollout::Feature class or similar meaningful implementation not breaking backward compatibility.