fffej/sql-server-gen

Partition functions don't have a "GO" batch marker

Closed this issue · 1 comments

At the moment, the generator produces code like:

CREATE PARTITION FUNCTION UUID_f301e41e1f3e77a11d1628cad2118f60 (nchar)
AS RANGE RIGHT FOR VALUES ('r',
                           'h',
                           't',
                           'o',
                           'n',
                           'w',
                           'f')
CREATE PARTITION FUNCTION UUID_d1286b83b0d3e13919201bc402579e63 (uniqueidentifier)
AS RANGE LEFT FOR VALUES ('a8902e49-7671-e985-75a2-0922c5f51c2d')
CREATE PARTITION FUNCTION UUID_5971bd050f582668d37fda6b17e3a5f0 (binary(5392))
AS RANGE RIGHT FOR VALUES (10,
                           -2,
                           -3,
                           5,
                           8,
                           2,
                           -15,
                           -6,
                           1,
                           6,
                           -9)

There should be GO statements between each partition function.

It looks like you can probably just add the string "GO" somewhere around https://github.com/fffej/sql-server-gen/blob/master/src/Database/SqlServer/Create/PartitionFunction.hs#L66

fffej commented

Yup, that sucks. Fix is pretty simple, want to have a crack?