fgci-org/ansible-role-cuda

Improve score on ansible galaxy

Closed this issue · 6 comments

Turns out galaxy also has some points system where we now only have 2.5/5 :(

https://galaxy.ansible.com/cscfi/cuda

Syntax Score:0.5
Warnings: 9
3E303: systemctl used in place of systemd module
5E601: Don't compare to literal True/False
1E305: Use shell only when shell functionality is required

Metadata Score:4.5
Warnings: 1
1E702: Use 'galaxy_tags' rather than 'categories'

All fixed, maybe it is better now.

Well, almost all. Score is good enough for me now.

Nice that those shell chroot commands aren't needed with the image creates anymore!

Hmm, hope not.

Some of the patches broke containers, reverted those.

Quality score now 3.5 / 5. I am not touching this one anymore. If somebody wants to further improve it feel free to reopen the issue.