spurious newline added when diff contains a list with new elements

Question

spurious newline added when diff contains a list with new elements

t3chguy opened this issue 5 years ago · 4 comments

When applied, this diff looks like

Additionally, this diff could be simplified to just a single step and that would hugely clean it up.

Answer 1 · 2020-09-25T20:21:40.000Z

Hey, the newline that is being added is because there is another textnode with a newline in it. This currently spans over 3 diffs, which could be cut down to 2 under perfect conditions. I think this looks quite acceptable though.

Answer 2 · 2020-09-25T20:22:15.000Z

If you want to investigate it more and write a patch, I'd be happy to merge it @t3chguy .

Answer 3 · 2020-09-28T12:36:01.000Z

@t3chguy I received a message that you commented on this issue, but the comment seems to have disappeared.

Answer 4 · 2020-09-28T12:40:41.000Z

Yup, I deleted it, it was moot and a bad reproduction case.