filamentgroup/loadCSS

Firefox Bug - Crash issues with Version <= 41 and loadCSS v2.0.1

duply opened this issue · 7 comments

duply commented

Hi,

I recently updated to loadCSS v.2.0.1 and noticed that older Firefox Versions completely crash the Browser on pageload.
Using Browserstack I narrowed it down to Firefox 41 and below. Not exactly sure what's causing this. Reverting back to loadCSS v1.3.1 resolved the issue though.

I can reproduce the error using the demo page and Firefox 41:
https://master-origin-loadcss.fgview.com/test/preload.html

gaaarg commented

Hello,

Any updates about this issue ?
Is it something the filamentgroup will plan to fix?

rsteinwand commented

I can confirm it's a problem for my website as well.

But I have no clue if any of our customers use FF 41.

ryantoft-gm commented

Usage on FF 41 and earlier is going to be low. But the fact that it crashes the whole browser is pretty rough.

For what it's worth it looks like the issue was introduced in this commit - likely related to the way the load handlers were changed: afa545b

scottjehl commented

good to know thanks!

gaaarg commented

FYI
It was said in the #262 discussion that the 918a331 resolve also this issue. I test it and it works fine in FF 41.

So it seems that using the last version of the master branch (but not tagged) fix this.
Any reason why this commit has not been tagged ?

Link to the CSS PreLoad function that I used:
https://github.com/filamentgroup/loadCSS/blob/918a3318f055002b4bee729840e420e057637c7a/src/cssrelpreload.js

c-vetter commented

@scottjehl Can this be closed? The commit in question should be in the 2.1.0 release.

Maybe @duply or @rsteinwand can confirm it's fixed?

gaaarg commented

@rasenplanscher we update to v 2.1.0 and seems to works fine in FF41 & IE 11