Add tooling so releasing doesn't happen out of code review
Closed this issue · 2 comments
BigLep commented
Done Criteria
The release steps outlined in #273 can be followed without requiring manual clicking in the GitHub UI. Instead, releases should occur as a result of an approved PR.
Why Important
The release process in #273 doesn't have any peer review. Mistakes can get made. Mistagging has happened in the past and can't be reverted. This is usually fixed by just doing another release, but this adds unnecessary confusion.
User/Customer
Maintainers
Notes
- @BigLep knows Lotus Maintainers had understandably made tagging mistakes in the past (it's inevitable). I don't recall the specific instances off hand though. I believe though that this is what helped fuel some of the "version.json" work for "unified CI".
- @BigLep's knowlege about the permanence of git tags may be out of date.
BigLep commented
2024-06-18: per triage conversation, mistakes here aren't as significant given go-state-types is in the middle layer. The concern on adding a review step is that it will increase the calendar time for a release.