`eth_getTransactionCount` seem to fail when passing `pending` and `finalized`

[virajbhartiya]

Checklist

• This is not a security-related bug/issue. If it is, please follow please follow the security policy.
• I have searched on the issue tracker and the lotus forum, and there is no existing related issue or discussion.
• I am running the Latest release, the most recent RC(release canadiate) for the upcoming release or the dev branch(master), or have an issue updating to any of these.
• I did not make any code changes to lotus.

Lotus component

• lotus daemon - chain sync
• lotus fvm/fevm - Lotus FVM and FEVM interactions
• lotus miner/worker - sealing
• lotus miner - proving(WindowPoSt/WinningPoSt)
• lotus JSON-RPC API
• lotus message management (mpool)
• Other

Lotus Version

Daemon:  1.29.3-dev+2k+git.a112b0945+api1.5.0
Local: lotus version 1.29.3-dev+2k+git.a112b0945

Repro Steps

curl --location --request POST 'http://localhost:1234/rpc/v1' --header 'Content-Type: application/json' --data-raw '{"jsonrpc": "2.0","method": "eth_getTransactionCount", "params": ["0x742d35Cc6634C0532925a3b844Bc454e4438f44e","pending"], "id": 1}'

Describe the Bug

When passing pending it returns the error:

{"error":{"code":1,"message":"failed to get nonce from mpool: resolution lookup failed (f410foqwtltdggtafgkjfuo4ejpcfjzcdr5cojeqn5ti): resolve address f410foqwtltdggtafgkjfuo4ejpcfjzcdr5cojeqn5ti: actor not found"},"id":1,"jsonrpc":"2.0"}

For finalized and safe it returns:

{"error":{"code":-32700,"message":"unmarshaling params for 'eth_getTransactionCount' (param: *ethtypes.EthBlockNumberOrHash): invalid block param"},"id":1,"jsonrpc":"2.0"}

While passing latest works just fine,

{"id":1,"jsonrpc":"2.0","result":"0x0"}

Logging Information

2024-10-02T15:59:43.276+0530	WARN	rpc	go-jsonrpc@v0.6.0/handler.go:474	error in RPC call to 'eth_getBlockByNumber': failed to get tipset:
    github.com/filecoin-project/lotus/node/impl/full.(*EthModule).EthGetBlockByNumber
        /Users/art3mis/Developer/protocol/lotus/node/impl/full/eth.go:352
  - block param "earliest" is not supported
2024-10-02T15:59:59.232+0530	WARN	rpc	go-jsonrpc@v0.6.0/handler.go:474	error in RPC call to 'eth_getBlockByNumber': failed to get tipset:
    github.com/filecoin-project/lotus/node/impl/full.(*EthModule).EthGetBlockByNumber
        /Users/art3mis/Developer/protocol/lotus/node/impl/full/eth.go:352
  - block param "earliest" is not supported
2024-10-02T16:01:13.925+0530	WARN	rpc	go-jsonrpc@v0.6.0/handler.go:474	error in RPC call to 'eth_getTransactionCount': failed to get nonce from mpool:
    github.com/filecoin-project/lotus/node/impl/full.(*EthModule).EthGetTransactionCount
        /Users/art3mis/Developer/protocol/lotus/node/impl/full/eth.go:489
  - resolution lookup failed (f410foqwtltdggtafgkjfuo4ejpcfjzcdr5cojeqn5ti):
    github.com/filecoin-project/lotus/chain/state.(*StateTree).GetActor
        /Users/art3mis/Developer/protocol/lotus/chain/state/statetree.go:373
  - resolve address f410foqwtltdggtafgkjfuo4ejpcfjzcdr5cojeqn5ti:
    github.com/filecoin-project/lotus/chain/state.(*StateTree).lookupInternalIDAddress
        /Users/art3mis/Developer/protocol/lotus/chain/state/statetree.go:338
  - actor not found
2024-10-02T16:01:46.457+0530	ERROR	rpc	go-jsonrpc@v0.6.0/server.go:139	RPC Error: unmarshaling params for 'eth_getTransactionCount' (param: *ethtypes.EthAddress): expected hex string length sans prefix 40, got 64
2024-10-02T16:01:46.457+0530	WARN	rpc	go-jsonrpc@v0.6.0/server.go:149	rpc error: unmarshaling params for 'eth_getTransactionCount' (param: *ethtypes.EthAddress): expected hex string length sans prefix 40, got 64
2024-10-02T16:02:04.759+0530	WARN	rpc	go-jsonrpc@v0.6.0/handler.go:474	error in RPC call to 'eth_getTransactionCount': failed to get nonce from mpool:
    github.com/filecoin-project/lotus/node/impl/full.(*EthModule).EthGetTransactionCount
        /Users/art3mis/Developer/protocol/lotus/node/impl/full/eth.go:489
  - resolution lookup failed (f410foqwtltdggtafgkjfuo4ejpcfjzcdr5cojeqn5ti):
    github.com/filecoin-project/lotus/chain/state.(*StateTree).GetActor
        /Users/art3mis/Developer/protocol/lotus/chain/state/statetree.go:373
  - resolve address f410foqwtltdggtafgkjfuo4ejpcfjzcdr5cojeqn5ti:
    github.com/filecoin-project/lotus/chain/state.(*StateTree).lookupInternalIDAddress
        /Users/art3mis/Developer/protocol/lotus/chain/state/statetree.go:338
  - actor not found
2024-10-02T16:03:23.171+0530	ERROR	rpc	go-jsonrpc@v0.6.0/server.go:139	RPC Error: unmarshaling params for 'eth_getTransactionCount' (param: *ethtypes.EthBlockNumberOrHash): invalid block param
2024-10-02T16:03:23.171+0530	WARN	rpc	go-jsonrpc@v0.6.0/server.go:149	rpc error: unmarshaling params for 'eth_getTransactionCount' (param: *ethtypes.EthBlockNumberOrHash): invalid block param
2024-10-02T16:03:47.086+0530	ERROR	rpc	go-jsonrpc@v0.6.0/server.go:139	RPC Error: unmarshaling params for 'eth_getTransactionCount' (param: *ethtypes.EthBlockNumberOrHash): invalid block param
2024-10-02T16:03:47.086+0530	WARN	rpc	go-jsonrpc@v0.6.0/server.go:149	rpc error: unmarshaling params for 'eth_getTransactionCount' (param: *ethtypes.EthBlockNumberOrHash): invalid block param

[aarshkshah1992]

@virajbhartiya I don't think this API is expected to work with "finalised"/safe" as "finalised"/"safe" does not point to a specific block.

It is only expected to work for "earliest", "latest" and "pending". So a green itest for all 3 would be great.
Also, please also write tests for cases where we pass in a specific "blockhash"/"blocknumber".