Make the `GetTipsetByHeight` in-memory skip list cache persistent for finalised tipsets
aarshkshah1992 opened this issue · 3 comments
When a Lotus node starts up, it kicks-off a "prefilling" of the in-memory GetTipsetByHeight cache in a go-routine. See here.
On Archival nodes, this pre-filling can take hours (RPC queries for tipsets way in the past will take a really long time/fail till this cache is pre-filled). However, because the cache is in-memory, the pre-filling needs to be done all over again once the node restarts.
Once the ChainIndexer ships -> we should re-engineer the GetTipsetByHeight cache to use the persistent ChainIndexer atleast for finalised tipsets. We should also investigate if there's a strong reason to not do this for non-finalised tipsets.
This will improve UX for Archival RPC providers and also speed up RPC queries for finalised tipsets immediately after node boot up.
Glif's archival node only took 3 hours for the hydration all the way upto genesis. So it's bad but not that bad.
Note that we need the ChainIndexer to be deployed and backfilled on nodes before we can use it to replace the skiplist in the tipset cache.