ChainValidateIndex should validate the actual content of the events and not just match on the number of events

Question

ChainValidateIndex should validate the actual content of the events and not just match on the number of events

aarshkshah1992 opened this issue 3 months ago · 3 comments

aarshkshah1992 commented 3 months ago

The ChainValidateIndex currently only compares the counts of the events in the Index with the number of events for the epoch in the Index to validate the Indexed events.

However, we should also compare the actual content of the events in the chain state AMT with the Indexed events for a more comprehensive check.

See #12570 and #12571 for exploration of more complete checking.

Answer 1 · 2024-10-14T16:13:35.000Z

@aarshkshah1992 : I'm not close to the details, but #12571 is related right?

Answer 2 · 2024-10-15T04:27:13.000Z

yes, #12571 is the implementation for lotus-shed, all the hard logic is explored in there so a lot of that code can just be copied, like the original counting code was copied from there

Answer 3 · 2024-10-23T10:35:22.000Z

Closed by #12632.