filecoin-project/ref-fvm

Implement external iteration for the KAMT

Stebalien opened this issue · 3 comments

Port the changes in #1833 to the KAMT. This should be fairly straight-forward.

Hey @Stebalien I am working on this issue, I am writing iter.rs for kamt types referring to that implemented for hamt types, I could not find the load function for node in kamt type so as to implement the Link case for next node as done here for hamt type. Should I have to write the load function for kamt node or am I doing something wrong, would be great if you could help.

Would be great if you could see the way I am trying to implement iter.rs for kamt types here and let me know if its not the correct way.

I am currently on vacation and won't be back for a few weeks. However, I think the answer is no.

See the original implementation in https://github.com/filecoin-project/ref-fvm/pull/1833/files. The load function came afterwards and exists to perform more paranoid validation. I'd like to port that as well, but that's a separate task.

Hey @Stebalien raised a pr resolving this #1958 . Feel free to review it whenever you get time.