issues in using refac tool for batch 5

[neelravi]

Following errors show up to the files listed after using refac tool

• psi.f

  1. • Line 99, 140, 144 Variable psia does not have a type
  2. • Line 150, 192, 196, 197, 201, 202 Variable psib does not have a type

• rannyu.f

  1. • Line 42 function rannyu does not have a type
  2. • Line 42 variable idum does not have a type

• read_data.f90
  The refac tool gives "substring not found error"

    scope = clean_statements(args)
  File "/home/ravindra/.local/lib/python3.8/site-packages/refac/clean_use_and_implicit.py", line 124, in clean_statements
    scopes = fill_scopes(rawdata, scopes, clean_implicit)
  File "/home/ravindra/.local/lib/python3.8/site-packages/refac/scope_utils.py", line 72, in fill_scopes
    scope = fill_characters(scope)
  File "/home/ravindra/.local/lib/python3.8/site-packages/refac/scope_utils.py", line 182, in fill_characters
    declaration = separate_dimensions(list_to_string(sd[1:]))
  File "/home/ravindra/.local/lib/python3.8/site-packages/refac/scope_utils.py", line 273, in separate_dimensions
    variables.append(variable[:variable.index("(")])
  

ValueError: substring not found```

• readps_gauss.f

  1. • Line 165 The statement real(dp) :: dp, dv, dvpot, e, p is confusing for a variable named dp (a parameter). Compiler says "attributes of this name conflict with those made accessible by a USE statement"
  2. • Line 176, 179 variable "dp" causes "This PARAMETER constant name is invalid in this context"

• readps_tm.f

  1. • Line 28 real(dp) :: 2i6, dabs, dpot1, dpotn, val . Compiler Syntax error, found INTEGER_CONSTANT

• rotqua.f
  catastrophic error: Too many errors, exiting. This file needs manual checking. The refac tool does not do its job. A lot of variables are undeclared.

• set_input_data.f90

  1. • Line 109. "idiff" does not have a type
  2. • Line 392. "nterms4(...)" does not have a type

• sites.f

  1. • Line 44 "rannyu" does not have a type
  2. • Line 44 "dlog(rannyu(0))" This argument's data type is incompatible with this intrinsic procedure; procedure assumed EXTERNAL
  3. • Line 44 "dlog" This name does not have a type

• spline.f
  Too many errors. This file needs manual checking. The refac tool fails somehow as the variables are typed in capital, and the refac tool does not declare simple variables such as X or K or N.

• strech.f

  1. • Line 40 real(dp) :: ALLOCATABLE,, PCM, ajacob, cc, cc1 Syntax error found extra comma

[NicoRenaud]

closed by #132