parse_metadata for user-supplied xml string

Question

parse_metadata for user-supplied xml string

vladpopovici opened this issue 2 years ago · 2 comments

I try to parse an OME XML string read outside the OMETIFFReader object, using the OMETIFFReader.parse_metadata(s) function. However, this function always parses the internal attribute "self.omexml_string" instead of the argument string ("omexml_string"). I suggest modifying line 54 from pyometiff/omereader.py by dropping "self." from "self.omexml_string".

Thanks a lot for this nice package!

Answer 1 · 2023-03-17T09:07:19.000Z

uh, that's definetly a typo on my part!
Thank you for noticing and opening the issue, I'll fix it and draft a new release ASAP.

Answer 2 · 2023-03-17T09:43:20.000Z

Solved issue in 27e5c5b and published fix on release 0.0.12, which you should now be able to install via pip install --upgrade pyometiff
Thanks for contributing!