filllabs/dependi

Fail to order pre-release versions for Python dependencies

Closed this issue · 7 comments

shunichironomura commented

Describe the bug
The extension displays ❌ with the pre-release version next to the newer stable version.

To Reproduce

  1. Prepare a requirements.txt with the following content:
typer==0.12.3
datashader==0.16.3
  1. Open the file in VS Code with the extension. The extension displays ❌ 0.12.dev2 for typer and ❌ 0.16.3rc0 for datashader. The extension settings are all set to defaults.

Expected behavior
The extension shows ✅ for both cases, as they are the latest stable versions. Also, I want "0.12.dev2" to be regarded as older than "0.12.3" and "0.16.3rc0" older than "0.16.3".

The Semantic Versioning requires a hyphen between the version core and pre-release, and I'm guessing that may be the cause of this. But it seems to be the standard in Python. See Version specifiers - Python Packaging User Guide.

Screenshots
image

Desktop (please complete the following information):

  • OS: Linux (WSL2 Ubuntu)
  • Version: v0.7.5
JP-Ellis commented

As a whole, pre-releases should probably not be recommended at all. Most Python tools require to explicitly opt-in to pre-releases when dependencies are installed.

serayuzgur commented

As a whole, pre-releases should probably not be recommended at all. Most Python tools require to explicitly opt-in to pre-releases when dependencies are installed.

Thanks for the info. We defined a setting for that , means they are excluded by default but if you insist yo see them.

serayuzgur commented

@shunichironomura does this works for you ?
image

shunichironomura commented

@serayuzgur Yes, that's what I expect to see.

JP-Ellis commented

I still have an instance where a pre-release is being shown:

image

Not sure whether that is an edge case due to the ~=0.0 selection.

serayuzgur commented

I still have an instance where a pre-release is being shown:

image Not sure whether that is an edge case due to the `~=0.0` selection.

This will fix it

MOzanGul commented

Hi @shunichironomura , we have fixed this issue per your request.
We'd be really happy if you could review Dependi, here is our reviews page.

  • 👍1